Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-crt-cpp/0.30.0 package update #40930

Closed
wants to merge 2 commits into from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Jan 30, 2025

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Jan 30, 2025
Copy link
Contributor Author

octo-sts bot commented Jan 30, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

• Detected Error: mv: can't rename '/home/build/melange-out/aws-crt-cpp/usr/lib/aws-crt-cpp': No such file or directory

• Error Category: Configuration/Pipeline

• Failure Point: Subpackage pipeline for aws-crt-cpp-dev during the split/dev step

• Root Cause Analysis:
The error occurs because the pipeline is trying to move a directory that doesn't exist. The CMake installation puts files in different locations than what the subpackage pipeline expects.

• Suggested Fix:
Modify the subpackage pipeline to move the correct files. Replace the existing pipeline with:

  - name: aws-crt-cpp-dev
    description: aws-crt-cpp dev
    pipeline:
      - uses: split/dev
      - runs: |
          mkdir -p "${{targets.subpkgdir}}"/usr/lib/cmake
          mv "${{targets.destdir}}"/usr/lib/cmake/aws-crt-cpp "${{targets.subpkgdir}}"/usr/lib/cmake/

• Explanation:
The CMake build system installs the development files under /usr/lib/cmake/aws-crt-cpp instead of /usr/lib/aws-crt-cpp. The fix updates the path to match the actual installation location.

• Additional Notes:

  1. The CMake configuration uses standard installation paths
  2. Header files are handled automatically by split/dev
  3. The fix ensures development files are properly packaged
  4. No changes needed to main package configuration

• References:

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Jan 30, 2025
@debasishbsws debasishbsws self-assigned this Jan 30, 2025
- Replaced custom build steps with Melange standard CMake pipelines (configure, build, install).
- Removed manual handling of aws-c-mqtt dev folder, as it is now managed upstream

Signed-off-by: Debasish Biswas <[email protected]>
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Jan 30, 2025
@debasishbsws debasishbsws requested a review from a team January 30, 2025 20:13
@octo-sts octo-sts bot closed this Jan 30, 2025
Copy link
Contributor Author

octo-sts bot commented Jan 30, 2025

superseded by #40944

@octo-sts octo-sts bot deleted the wolfictl-b81b8479-90d0-4659-8da5-4b7e3ecd12b1 branch January 31, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants