Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flyway/11.3.0 package update #40896

Closed
wants to merge 6 commits into from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Jan 30, 2025

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Jan 30, 2025
Copy link
Contributor Author

octo-sts bot commented Jan 30, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

• Detected Error: "Could not transfer artifact org.flywaydb:flyway-database-ignite:pom:10.17.0 from/to flyway-community-db-support (https://maven.pkg.github.com/flyway/flyway-community-db-support): status code: 401, reason phrase: Unauthorized (401)"

• Error Category: Dependency Resolution/Authentication

• Failure Point: Maven dependency resolution during build, specifically when trying to fetch the flyway-database-ignite dependency

• Root Cause Analysis: The build is failing because it's trying to access a private GitHub package repository without proper authentication. Flyway has moved some database support packages to a separate repository that requires authentication.

• Suggested Fix:

  1. Add -pl !flyway-database-ignite to the Maven command in the build pipeline to exclude the ignite module:
  - name: Install
    runs: |
      # Build flyway
      ./mvnw -B clean dependency:copy-dependencies package -e --file pom.xml -DskipTests -pl !flyway-database-mongodb,!flyway-database-ignite

• Explanation: By excluding the ignite module from the build, we avoid the need to authenticate against the private repository. The ignite module is not required for core Flyway functionality and is part of Flyway Teams edition.

• Additional Notes:

  • This is a common issue with Flyway 11+ as some database support has been moved to separate repositories
  • The exclusion won't affect core Flyway functionality
  • Alternative approach would be to provide GitHub authentication, but that's not necessary for basic Flyway usage
  • The changed command maintains compatibility with Flyway's open-source feature set

• References:

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Jan 30, 2025
@OddBloke OddBloke self-assigned this Jan 30, 2025
@OddBloke
Copy link
Member

The build is failing because we get a 401 when we attempt to fetch packages from maven.pkg.github.com. However, I think Maven is only trying to hit GitHub's (private?) package repository because not all of the 10.17.0 packages for flyway-community-db-support have been published to Maven Central, so it's falling back. I've filed flyway/flyway-community-db-support#77 upstream to report the problem.

Copy link
Contributor Author

octo-sts bot commented Feb 4, 2025

superseded by #41271

@OddBloke OddBloke deleted the wolfictl-9d2b6125-846a-4064-a5e7-1ee36f3a1118 branch February 4, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR automated pr request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants