Add liblmdb.so and liblmdb.so.0 symlinks #39912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octo-sts
bot
added
the
bincapz/pass
sil2100
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Thanks Brian! So I think the proper fix for this would be to either modify the 0001-Debian-quirks-to-make-shared-library-versioned.patch patch or add another one next to it - because the patch is IMO incomplete. This patch adds the multi-versioned-so bits, but forgets to touch the make install target to not follow symlinks, resulting in this issue.
However, since it's part of an escalation and basically adding a new patch is as invasive as just doing it via melange - let me merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of resolving https://github.com/chainguard-dev/customer-issues/issues/1975 where installing samba-client complains that liblmdb.so.0 is not a symlink: