Skip to content

feat(makefile): set default melange runner to docker #32207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

maxgio92
Copy link
Member

@maxgio92 maxgio92 commented Oct 29, 2024

Continuous integration and automation runs pipelines in Docker with Melange, in order to provide consistency and homogeneous environment, it sets the default runner to Docker. The Make variable can be inherited and overridden.

Related:

Continuous integration and automation runs pipelines in Docker with Melange,
in order to provide consistency and homogeneous environment, it sets the
default runner to Docker. The Make variable can be inherited and overridden.

Signed-off-by: Massimiliano Giovagnoli <[email protected]>
Copy link
Member

@xnox xnox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice! as this makes it easier to use preffered runner. And makes local default be the current production default.

@maxgio92 maxgio92 marked this pull request as ready for review October 29, 2024 16:05
@maxgio92 maxgio92 requested a review from a team as a code owner October 29, 2024 16:05
Copy link
Member

@89luca89 89luca89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this too 👍 Seems a sensible thing to do

@xnox xnox merged commit 0b06f8e into wolfi-dev:main Oct 29, 2024
13 checks passed
rawlingsj added a commit that referenced this pull request Oct 29, 2024
imjasonh pushed a commit that referenced this pull request Oct 29, 2024
Reverts #32207

We're seeing errors on PRs

```
 ERRO failed to build package: unable to start pod: Error response from daemon: invalid mount config for type "bind": bind source path does not exist: /github/home/.melangecache
```


https://github.com/wolfi-dev/os/actions/runs/11578666199/job/32233101978?pr=32221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants