JSON-Output Option for stdout.#116
Open
Ra0R wants to merge 7 commits into
Open
Conversation
wolfgangw
reviewed
Mar 26, 2026
wolfgangw
reviewed
Mar 26, 2026
| :info => inspection[ :info ], | ||
| } | ||
| puts JSON.pretty_generate( payload ) | ||
| exit inspection[ :errors ].size == 0 ? DCP_OK : DCP_ERROR |
Owner
There was a problem hiding this comment.
Exiting here would leave @dcp_inspect_tmp dangling
wolfgangw
reviewed
Mar 26, 2026
| end | ||
| if options.json_output | ||
| options.verbosity = [ 'quiet' ] | ||
| # TODO: Or should the JSON output be written to a file instead of stdout? Then we could have autolog and logfile options for JSON output as well. |
Owner
There was a problem hiding this comment.
Yes, should reuse the autolog and logfile mechanisms
Owner
|
Renato, hi and thanks, I like it. Can I ask, are you using dcp_inspect yourself? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there, I implemented a JSON-Output option to stdout.
Feel free to pull it if it fits the project. I left a todo, in case the output should also be written to a logfile. But I didn't want to change too much.