refactor to Make(Dhe)PSKPreMasterSecret

[effbiae]

Description

pull out common code to utility functions

• AddPSKtoPreMasterSecret
• MakePSKPreMasterSecret
• MakeDhePSKPreMasterSecret

Testing

unit tests don't seem to cover this code very well

Checklist

• added tests
• updated/added doxygen
• updated appropriate READMEs
• Updated manual and documentation

[devin-ai-integration]

🛟 Devin Lifeguard found 2 likely issues in this PR

• check-all-return-codes snippet: Capture the return value of MakeDhePSKPreMasterSecret(ssl, 0) and, if it is non-zero, propagate the error (e.g., if (MakeDhePSKPreMasterSecret(ssl, 0) != 0) ERROR_OUT(PSK_KEY_ERROR, exit_scke);).
• no-void-functions snippet: Change static void MakePSKPreMasterSecret(Arrays* arrays) to static int MakePSKPreMasterSecret(Arrays* arrays) and have it return 0 on success (or an error code on failure) so callers can propagate errors instead of assuming success.

@effbiae
please take a look at the above issues which Devin flagged. Devin will not fix these issues automatically.

[wolfSSL-Bot]

Can one of the admins verify this patch?

[dgarske]

Contributor agreement on file. Okay to test

[dgarske]

Jenkins retest this please: "fips_ready_part1only" failed

[dgarske]

Nice little cleanup.

[effbiae]

what happened in the jenkins failures?

[dgarske]

Jenkins retest this please.

./configure flags: --enable-all
(1 Error in this section)
FAIL: scripts/openssl.test

[SparkiDev]

retest this please

openssl.test failures

[dgarske]

Jenkins retest this please

[dgarske]

Kernel module build errors not related to PR. Fixed in PR 9319.

[dgarske]

Jenkins retest this please. Seeing some openssl.test failures.

[dgarske]

Jenkins retest this please.

[dgarske]

@effbiae will you please rebase and force push this PR to resolve the test errors? Thank you

[dgarske]

@effbiae there appears to be a regression issue with interop. Steps to reproduce:

export WOLFSSL_OPENSSL_TEST=1
./autogen.sh
./configure --enable-all
make
make check
FAIL: scripts/openssl.test

# ./examples/client/client -p 57884 -g -r -l DHE-PSK-AES256-GCM-SHA384 -s  "-c/home/davidgarske/GitHub/wolfssl/scripts/../certs/client-cert.pem" "-k/home/davidgarske/GitHub/wolfssl/scripts/../certs/client-key.pem" "-A/home/davidgarske/GitHub/wolfssl/scripts/../certs/ca-cert.pem"
connecting to 127.0.0.1:57884
wolfSSL_connect error -313, received alert fatal error
wolfSSL error: wolfSSL_connect failed
client failed! Suite = DHE-PSK-AES256-GCM-SHA384 version =

[effbiae]

i was too aggressive in the refactor. see latest commit for special casing of MakePSKPreMasterSecret
can you see a better way of special casing than passing the byte use_psk_key here?

note i need to squash the two commits before merge

[dgarske]

Jenkins retest this please: "'PRB-long-runtime.txt_1"

[dgarske]

This looks much better and seems to be passing the tests now.