Various improvements to iscacii and CMake key log #8596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2025
|
Retest this please: "Found unhandled hudson.remoting.RequestAbortedException exception:" |
* Detect 'isascii' at configuration (tested with `./configure CFLAGS="-DNO_STDLIB_ISASCII" && make check`). * Add mew CMake option `WOLFSSL_KEYLOG_EXPORT` (fixes wolfSSL#8165) Replaces PR wolfSSL#8174 and wolfSSL#8158. Thank you @redbaron.
dgarske
force-pushed
the
various_isacii_keylog
branch
from
8e26543 to
a59075b
Compare
|
Retest this please |
SparkiDev
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various improvements to iscacii and CMake key log:
./configure CFLAGS="-DNO_STDLIB_ISASCII" && make check).WOLFSSL_KEYLOG_EXPORT(fixes CMake buid scripts don't offer--enable-keylog-exportlike option #8165)Replaces PR cmake: new add_option_defs helper, add KEYLOG_EXPORT build param #8174 and Detect 'isascii' at configuration stage #8158. Thank you @redbaron.
Testing
Checklist