ARM32/Thumb2 ASM: fix WOLFSSL_NO_VAR_ASSIGN_REG #8590
Merged
+1,162
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thumb2 needed constants defined even with no register assignments. ARM32 needed support added fo rnot having registers assigned to variables.
tmael
reviewed
Mar 26, 2025
Compiler doesn't keep parameters in the same registers as passed if they are output registers.
Greenhills compiler doesn't accept volatile and __asm__ needs to be __asm.
|
retest this please |
tmael
approved these changes
Mar 29, 2025
JacobBarthelmeh
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thumb2 needed constants defined even with no register assignments. ARM32 needed support added fo rnot having registers assigned to variables.
Testing
./configure --disable-shared LDFLAGS=--static --host=armv7m CC=arm-linux-gnueabi-gcc --enable-armasm=inline
./configure --disable-shared LDFLAGS=--static --host=armv7m CC=arm-linux-gnueabi-gcc --enable-armasm=inline CFLAGS=-DWOLFSSL_NO_VAR_ASSIGN_REG
./configure --disable-shared LDFLAGS=--static --host=armv7a CC=arm-linux-gnueabihf-gcc --enable-armasm=inline
Checklist