Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverity: tests quic cleanup. #8537

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

coverity: tests quic cleanup. #8537

wants to merge 6 commits into from

Conversation

philljj
Copy link
Contributor

@philljj philljj commented Mar 6, 2025 •
edited
Loading

Description

Clean up tests/quic.c:

  • Use Expect* macros instead of Asserts. Fixes a bunch of coverity dead_error_condition: warnings, because ret value was never updated or checked.
  • Clean up line lengths.
  • Fix some c89-clang-tidy warnings (uninitialized data, mixing code and declarations, etc).

Testing

./configure --enable-quic --enable-earlydata --enable-session-ticket
make
./tests/unit.test

./wolfssl-multi-test.sh --with-prepared-wolfssl-workspace=/home/jordan/work/wolfssl/ \
   --no-result-cache all-c89-clang-tidy

@philljj philljj self-assigned this Mar 6, 2025
@philljj
Copy link
Contributor Author

philljj commented Mar 7, 2025

retest this please

@philljj philljj assigned wolfSSL-Bot and unassigned philljj Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wolfSSL-Bot wolfSSL-Bot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philljj @wolfSSL-Bot