Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digest tests: add more tests #8528

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SparkiDev
Copy link
Contributor

Description

Add testing of MD2 and Md4.
Add more tests of functions in hash.c.
Reformat data to match what is output by PRINT_DATA macro.

Testing

./configure '--disable-shared' '--enable-md2' '--enable-md4' '--enable-md5' '--enable-sha' '--enable-sha224' '--enable-sha384' '--enable-sha512' '--enable-sha3' '--enable-blake2' '--enable-blake2s' '--enable-ripemd' '--enable-sm3' '--enable-hashflags'
Regression tested digests.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@SparkiDev SparkiDev self-assigned this Mar 4, 2025
@SparkiDev SparkiDev force-pushed the digest_test_rework_2 branch 8 times, most recently from aa72a0a to c9bf19b Compare March 5, 2025 06:13
@SparkiDev
Copy link
Contributor Author

retest this please

@SparkiDev SparkiDev assigned wolfSSL-Bot and unassigned SparkiDev Mar 5, 2025
@SparkiDev SparkiDev requested a review from wolfSSL-Bot March 5, 2025 08:41
@SparkiDev SparkiDev removed the request for review from wolfSSL-Bot March 5, 2025 22:39
@SparkiDev SparkiDev requested a review from wolfSSL-Bot March 6, 2025 07:24
dgarske
dgarske previously approved these changes Mar 6, 2025
@dgarske dgarske assigned dgarske and douzzer and unassigned dgarske Mar 6, 2025
Copy link
Contributor

@douzzer douzzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valgrind trouble -- see attached.
pr8528_valgrind.txt

Add testing of MD2 and Md4.
Add more tests of functions in hash.c.
Reformat data to match what is output by PRINT_DATA macro.
@SparkiDev
Copy link
Contributor Author

retest this please

@SparkiDev SparkiDev removed their assignment Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants