-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Digest tests: add more tests #8528
Open
SparkiDev
wants to merge
1
commit into
wolfSSL:master
Choose a base branch
from
SparkiDev:digest_test_rework_2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa72a0a
to
c9bf19b
Compare
retest this please |
4 tasks
dgarske
previously approved these changes
Mar 6, 2025
douzzer
requested changes
Mar 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
valgrind
trouble -- see attached.
pr8528_valgrind.txt
Add testing of MD2 and Md4. Add more tests of functions in hash.c. Reformat data to match what is output by PRINT_DATA macro.
c9bf19b
to
e7ef3ab
Compare
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add testing of MD2 and Md4.
Add more tests of functions in hash.c.
Reformat data to match what is output by PRINT_DATA macro.
Testing
./configure '--disable-shared' '--enable-md2' '--enable-md4' '--enable-md5' '--enable-sha' '--enable-sha224' '--enable-sha384' '--enable-sha512' '--enable-sha3' '--enable-blake2' '--enable-blake2s' '--enable-ripemd' '--enable-sm3' '--enable-hashflags'
Regression tested digests.
Checklist