SP int: inline asm improvements and mont reduce simplifications #8527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SP int inline asm: - allow input variables to be either registers or memory for Intel x86/x64 (minor performance improvement) - don't have memory in clobber list if output variables are registers - remove empty clobber line in arm32/thumb2 code for old versions of gcc _sp_mont_red(): - simplify the code by not using extra variables - don't add to j in for loop check.
|
retest this please Hudson |
ribes96
reviewed
Mar 4, 2025
dgarske
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SP int inline asm:
_sp_mont_red():
Fixes #8523
Testing
Regression tested SP int code.
Checklist