Added ICMP sockets, DNS PTR. Refactored posix support #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
need to rebase. |
danielinux
force-pushed
the
icmp_sockets
branch
from
3aa7033 to
4e7bf9e
Compare
philljj
requested changes
Nov 21, 2025
- New poll/select mechanism actually blocking on events - Fix: sending syn-ack from accepted socket (listener may be closed meanwhile)
fixes connect()
danielinux
changed the title
danielinux
force-pushed
the
icmp_sockets
branch
from
1b25578 to
c968dcc
Compare
philljj
requested changes
Nov 24, 2025
Contributor
philljj
left a comment
philljj
left a comment
There was a problem hiding this comment.
Overall looks and tests good. Just found a few things, and a few suggestions.
philljj
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested via:
makesudo LD_PRELOAD=$PWD/libwolfip.so ping -c5 10.10.10.1(added a github action for this).
This new API can intercept/manage ICMP sockets open via
socket(AF_INET, SOCK_DGRAM, PROTO_ICMP), as used bypingin linux.