- 
          
- 
        Couldn't load subscription status. 
- Fork 966
Add ability to disable annotations including canvas appearance-data #968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful work!
Some comments I have:
- annotationModemust be documented.
- Having more unit tests would be great. I'll gladly help out.
- This technically deprecates renderFormsin favor of much more powerfulannotationMode, so renderForms is to be marked as deprecated (this one can be on me)
be758b5    to
    1a9897f      
    Compare
  
    1f184c5    to
    ef56712      
    Compare
  
    b14700a    to
    416e96c      
    Compare
  
    36a36d4    to
    e249af6      
    Compare
  
    d14ccb7    to
    744f655      
    Compare
  
    2d488c1    to
    a077571      
    Compare
  
    1f758cc    to
    ce6db03      
    Compare
  
    42a8c3c    to
    0d68fee      
    Compare
  
    d0aabb2    to
    736f3f3      
    Compare
  
    | How can I help to get this merged? | 
| 
 About (3) deprecating renderForms: we actually need to keep both renderForms and annotationMode as they serve distinct purposes. 
 Example: to show filled non-editable input {
  renderForms: false,
  annotationMode: ENABLE_STORAGE,
} | 
| Superseded by #1998 as this PR had to be rebased. | 
Closes #963