Using ABC

wobcom · Nov 19, 2024 · 800fe3c · 800fe3c
1 parent e2d7c85
commit 800fe3c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/cosmo/clients/netbox_client.py b/cosmo/clients/netbox_client.py
@@ -31,7 +31,7 @@ def query(self, query):
 
     def query_rest(self, path, queries):
         q = urlencode(queries, doseq=True)
-        url = urljoin(self.url, path) + f"?{q}",
+        url = urljoin(self.url, path) + f"?{q}"
 
         return_array = list()
 

diff --git a/cosmo/clients/netbox_v4.py b/cosmo/clients/netbox_v4.py
@@ -1,12 +1,13 @@
 import json
+from abc import ABC, abstractmethod
 from builtins import map
 from multiprocessing import Pool
 from string import Template
 
 from cosmo.clients.netbox_client import NetboxAPIClient
 
 
-class ParallelQuery:
+class ParallelQuery(ABC):
 
     def __init__(self, client: NetboxAPIClient, **kwargs):
         self.client = client
@@ -17,15 +18,17 @@ def __init__(self, client: NetboxAPIClient, **kwargs):
     def fetch_data(self, pool):
         return pool.apply_async(self._fetch_data, args=(self.kwargs,))
 
+    @abstractmethod
     def _fetch_data(self, **kwargs):
-        raise NotImplementedError()
+        pass
 
     def merge_into(self, data_promise, data: object):
         query_data = data_promise.get()
         return self._merge_into(data, query_data)
 
+    @abstractmethod
     def _merge_into(self, data: object, query_result):
-        raise NotImplementedError()
+        pass
 
 
 class ConnectedDevicesDataQuery(ParallelQuery):