-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for float and int types as well as color for animator's valueFrom/valueTo. #17
Conversation
I test it with: |
This update was intended to address integer/float values as is used for properties such as strokeAlpha or fillAlpha. I was planning on diving into the color values soon. |
Thanks |
@ladhot This pull request now includes support for animating the vector path's color (e.g. |
Great, thank you! |
@wnafee Can you share this version to the maven central, please? |
@twyatt Doesn't work( When i use fillColor animation, I have errors. |
@Twinkle942910 Could you paste your error (i.e. stacktrace) and assets that are causing you problems? |
@twyatt Here's my error list LogCat
drawable/circle_vector.xml
drawable/circle_avd.xml
anim/color_cahnge.xml (The ploblem is here. I think)
And MainActivity
Sorry for bad formating( |
@twyatt And that works without
in drawable/circle_avd.xml |
@twyatt Sorry, but is there any solution?( |
@Twinkle942910 In your |
@twyatt I already tryed, and also added app:vc_valueType="intType", that changed nothing( |
Maybe refer to https://github.com/twyatt/vector-compat-test as a starting point? As it was the code I used to test the color implementation. |
@twyatt That's doesn't work, I tried( #And Logs
|
@twyatt Maybe you just have to update project on maven? There might be an old version. |
@twyatt Are you here?) |
@Twinkle942910 This pull request has yet to be accepted, so the changes are not in the version that appears in Maven. You can clone the repo which this pull request comes from and compile it for your project. |
@twyatt Thanks, I'll try |
Closing as I imagine people use |
Fix for issue #16.