Skip to content

Refactor: improve robustness #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kap1bala wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Refactor: improve robustness #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
68b041a
fix: wrong and obsolete tags
kap1bala Dec 6, 2025
3402e1f
feat: improve browser support messaging and serial help visibility
kap1bala Dec 6, 2025
06fef23
fix: improve serial help visibility and clean up HTML structure
kap1bala Dec 6, 2025
6d5b909
fix: remove unnecessary type attribute from script tag
kap1bala Dec 6, 2025
682bb7b
style: single quotes
kap1bala Dec 6, 2025
247524a
refactor: simplify resetCheckboxes function by using array iteration
kap1bala Dec 6, 2025
6d99307
Merge branch 'refactor/improve-v1-robustness' of https://github.com/k…
kap1bala Dec 6, 2025
df62edc
style: single quotes
kap1bala Dec 6, 2025
c8bd20f
pref: null-check
kap1bala Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 31 additions & 19 deletions index.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@
</head>
<body onload="checkSupported()">
<div id="overlay">
<div id="text"><font size="7">
<b>Web Installer under maintenance</b>
</font>
<div id="text">
<h1>Web Installer under maintenance</h1>
<br> The WLED web installer is currently out of service due to maintenance work and will be back online shortly.
<br><br> In the meantime, you can use the webinstaller provided by Wladi: <a href="https://wled-install.github.io/">https://wled-install.github.io/</a>
</div>
Expand All @@ -26,11 +25,30 @@
<div class="main">
<h2>Welcome to the WLED web installer!</h2>

<div id="unsupported" hidden>
Sorry, your browser is not yet supported!<br>
Please try on Desktop Chrome or Edge.<br>
Find binary files here:<br>
<a href="https://github.com/Aircoookie/WLED/releases" target="_blank">
<button class="btn" slot="activate">GitHub Releases</button>
</a>
</div>

<div id="flasher">

<ol>
<li>Plug in your ESP to a USB port. We will install WLED <span id="verstr">0.12.0</span> to it.</li>
<li id="coms">Hit "Install" and select the correct COM port. <a onclick="showSerialHelp()">No device found?</a></li>
<li id="coms">Hit "Install" and select the correct COM port.
<a id="showSerialHelp" onclick="showSerialHelp()">No device found?</a>
<p id="serialHelp" hidden>
You might be missing the drivers for your board.<br>
Here are drivers for chips commonly used in ESP boards:<br>
<a href="https://www.silabs.com/developers/usb-to-uart-bridge-vcp-drivers" target="_blank">CP2102 (square chip)</a><br>
<a href="https://github.com/nodemcu/nodemcu-devkit/tree/master/Drivers" target="_blank">CH34x (rectangular chip)</a><br><br>
Make sure your USB cable supports data transfer.<br><br>
</p>
</li>

<li>Get WLED installed and connected in less than 3 minutes!</li>
</ol><br><br>

Expand Down Expand Up @@ -96,23 +114,17 @@ <h2>Welcome to the WLED web installer!</h2>
<input class="radio__input" type="radio" value="debug" name="version" id="debug">
<label class="radio__label" for="debug" id="debug_label">DEBUG</label>
</div>
<br>
<div class="container inst-button">
<esp-web-install-button
id="inst"
manifest=""
>
<button class="btn" slot="activate">Install</button>
</esp-web-install-button><br>

</div>
<br></brY><br>Powered by <a href="https://esphome.github.io/esp-web-tools/" target="_blank">ESP Web Tools</a><br>
<br>
<div class="container inst-button">
<esp-web-install-button id="inst" manifest="">
<button class="btn" slot="activate">Install</button>
</esp-web-install-button><br>
</div>

<br><br>Powered by <a href="https://esphome.github.io/esp-web-tools/" target="_blank">ESP Web Tools</a><br>
CORS proxy by <a href="https://corsfix.com" target="_blank">Corsfix</a><br>
<br><a href="https://github.com/Aircoookie/WLED" target="_blank">GitHub</a>&emsp;<a href="https://kno.wled.ge" target="_blank">kno.wled.ge</a>

<script
type = "text/javascript"
src="script.js"
></script>
<script src="script.js"></script>
</body>
</html>
35 changes: 12 additions & 23 deletions script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,14 @@ function handleCheckbox(manifest, checkboxmanifest, primaryCheckbox) {
}

function resetCheckboxes() {
document.getElementById('ethernet').checked = false;
document.getElementById('ethernet').disabled = false;
document.getElementById('audio').checked = false;
document.getElementById('audio').disabled = false;
document.getElementById('test').checked = false;
document.getElementById('test').disabled = false;
document.getElementById('v4').checked = false;
document.getElementById('v4').disabled = false;
document.getElementById('debug').checked = false;
document.getElementById('debug').disabled = false;
const checkBoxIds = ['ethernet', 'audio', 'test', 'v4', 'debug'];
checkBoxIds.forEach(id => {
const checkbox = document.getElementById(id);
if (checkbox) {
checkbox.checked = false;
checkbox.disabled = false;
}
});
}

function checkSupported() {
Expand All @@ -63,20 +61,11 @@ function checkSupported() {
}

function unsupported() {
document.getElementById('flasher').innerHTML = `Sorry, your browser is not yet supported!<br>
Please try on Desktop Chrome or Edge.<br>
Find binary files here:<br>
<a href="https://github.com/Aircoookie/WLED/releases" target="_blank">
<button class="btn" slot="activate">GitHub Releases</button>
</a>`
document.getElementById('flasher').hidden = true;
document.getElementById('unsupported').hidden = false;
}

function showSerialHelp() {
document.getElementById('coms').innerHTML = `Hit "Install" and select the correct COM port.<br><br>
You might be missing the drivers for your board.<br>
Here are drivers for chips commonly used in ESP boards:<br>
<a href="https://www.silabs.com/developers/usb-to-uart-bridge-vcp-drivers" target="_blank">CP2102 (square chip)</a><br>
<a href="https://github.com/nodemcu/nodemcu-devkit/tree/master/Drivers" target="_blank">CH34x (rectangular chip)</a><br><br>
Make sure your USB cable supports data transfer.<br><br>
`;
document.getElementById('showSerialHelp').hidden = true;
document.getElementById('serialHelp').hidden = false;
}