Allow enabling/disabling the label popup in the UI #1479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
force-pushed
the
display-label-popup
branch
from
cce4633 to
2be1c91
Compare
Owner
|
sorry for the late response. I agree this should be in the settings. maybe in the menu? 
|
Contributor
Author
|
To be honest, workflow-wise, I think it would be nicer here, because you always see what the current mode is and it's one click to toggle the mode. In the View menu, it's not always visible, and it's two clicks (and additional cognitive load to find the option in the menu) to toggle the mode. Maybe, if you're concerned about the visual real estate the checkbox takes up, it could be moved to the Label List panel header (assuming Qt supports that)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on 34887ae (#271).
This makes the otherwise pretty obscure configuration setting visible in the label list instead:
When no label is selected (or available), the checkbox is disabled and forced on:
When a label is selected in the list, the user is free to select the checkbox: