Implement waitReadable and waitByteTime on Windows#269
Open
mrchipset wants to merge 3 commits intowjwwood:mainfrom
Open
Implement waitReadable and waitByteTime on Windows#269mrchipset wants to merge 3 commits intowjwwood:mainfrom
mrchipset wants to merge 3 commits intowjwwood:mainfrom
Conversation
Add a FILE_FLAG_OVERLAPPED flag when open the port Revise the Read and Write method to support Asynchronous I/O
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to implement timeout function of waitReadable, MS Asynchronized I/O feature is introduced with FILE_FALG_OVERLAPPED flag of CreateFileW method.
Both read and write method have been refactored to support asynchronized I/O.
I have briefly tested it with test_serial subproject. It seems work fine. Looking forward to more testing.