Use macOS clock_gettime in timespec_now if it's available. Reduces CPU usage.#267
Open
ajackson-adi wants to merge 1 commit intowjwwood:mainfrom
Open
Use macOS clock_gettime in timespec_now if it's available. Reduces CPU usage.#267ajackson-adi wants to merge 1 commit intowjwwood:mainfrom
ajackson-adi wants to merge 1 commit intowjwwood:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were finding high CPU usage on macOS when connected to very active serial connections. After running the XCode profiler it pointed to this function.
clock_gettime is available in macOS 10.12 and higher. This change is to use that if it's available. If they are targeting a lower macOS minimum version check it at runtime, otherwise do it at compile time.
CPU usage was reduced to a more acceptable level.