Skip to content

Fix mailto URIs with multiple recipients #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix mailto URIs with multiple recipients #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 20 additions & 17 deletions htmltest/check-link.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,23 +405,26 @@ func (hT *HTMLTest) checkMailto(ref *htmldoc.Reference) {
})
return
}
emailAddress, decodeErr := url.QueryUnescape(ref.URL.Opaque)
if decodeErr != nil {
hT.issueStore.AddIssue(issues.Issue{
Level: issues.LevelError,
Message: fmt.Sprintf("cannot decode email (%s): '%s'", decodeErr, ref.URL.Opaque),
Reference: ref,
})
return
}
formatErr := checkmail.ValidateFormat(emailAddress)
if formatErr != nil {
hT.issueStore.AddIssue(issues.Issue{
Level: issues.LevelError,
Message: fmt.Sprintf("invalid email address (%s): '%s'", formatErr, emailAddress),
Reference: ref,
})
return
// mailto URIs may contain multiple recipients separated by "," (https://datatracker.ietf.org/doc/html/rfc6068#autoid-2)
for _, recipient := range strings.Split(ref.URL.Opaque, ",") {
emailAddress, decodeErr := url.QueryUnescape(recipient)
if decodeErr != nil {
hT.issueStore.AddIssue(issues.Issue{
Level: issues.LevelError,
Message: fmt.Sprintf("cannot decode email (%s): '%s'", decodeErr, ref.URL.Opaque),
Reference: ref,
})
return
}
formatErr := checkmail.ValidateFormat(emailAddress)
if formatErr != nil {
hT.issueStore.AddIssue(issues.Issue{
Level: issues.LevelError,
Message: fmt.Sprintf("invalid email address (%s): '%s'", formatErr, emailAddress),
Reference: ref,
})
return
}
}
}

Expand Down
6 changes: 6 additions & 0 deletions htmltest/check-link_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,6 +595,12 @@ func TestMailtoEncoded(t *testing.T) {
tExpectIssueCount(t, hT, 0)
}

func TestMailtoMultipleRecipients(t *testing.T) {
// ignores valid mailto links
hT := tTestFile("fixtures/links/mailto_multiple_recipients.html")
tExpectIssueCount(t, hT, 0)
}

func TestMailtoEncodedInvalid(t *testing.T) {
// ignores valid mailto links
hT := tTestFile("fixtures/links/mailto_encoded_invalid.html")
Expand Down
9 changes: 9 additions & 0 deletions htmltest/fixtures/links/mailto_multiple_recipients.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<html>

<body>

<a href="mailto:[email protected],[email protected]">Mail me</a>.

</body>

</html>