Skip to content

Conversation

@adi-benz
Copy link

@adi-benz adi-benz commented Jul 7, 2025

Remove secrets from URLs when logging.

We use go-retryablehttp when uploading data to presigned URLs and retries are logging the URLs.

Before:

time=2025-07-06T21:56:49.423+03:00 level=DEBUG msg="retrying request" request="GET http://127.0.0.1:61087?X-Amz-Credential=SECRET&X-Amz-Signature=SECRET&X-Amz-Security-Token=SECRET (status: 500)" timeout=1s remaining=4

After:

time=2025-07-06T21:55:37.272+03:00 level=DEBUG msg="retrying request" request="GET http://127.0.0.1:61004 (status: 500)" timeout=1s remaining=4

@wiz-inc-wiz-sec
Copy link

wiz-inc-wiz-sec bot commented Jul 7, 2025

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities
Data Finding Sensitive Data
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations
SAST Finding SAST Findings 1 Low
Total 1 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@adi-benz adi-benz force-pushed the adi.benz/redact-presigned-url-secrets branch from c74e4da to 42f591a Compare July 7, 2025 08:56
@adi-benz adi-benz requested a review from dany74q July 7, 2025 09:03
@adi-benz adi-benz requested a review from dany74q July 7, 2025 09:41
@adi-benz adi-benz merged commit b7c5303 into master Jul 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants