Infra/incubator action sheet #3472
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… handling and styling
…option handling, Screen refactor
… headerProps to IncubatorActionSheetScreen
M-i-k-e-l
reviewed
Mar 31, 2025
There was a problem hiding this comment.
@adids1221
A very partial review, but I'm not sure how the GestureHandlerRootView change will affect the PR so I'm assigning it back
| @@ -36,6 +36,7 @@ type ActionSheetProps = { | |||
| message?: string; | |||
| /** | |||
| * Index of the option represents the cancel action (to be displayed as the separated bottom bold button) | |||
| * Relevant for Native IOS ActionSheet only | |||
There was a problem hiding this comment.
Let's add this to the API as well
| @@ -107,7 +107,7 @@ const FadedScrollView = (props: Props) => { | |||
|
|
|||
| if (children) { | |||
| return ( | |||
| <GestureHandlerRootView> | |||
| <> | |||
There was a problem hiding this comment.
This breaks TabController
Comment on lines
+9
to
+15
| titleLength: TEXT_LENGTH.NO_TEXT, | ||
| titleIsProminent: false, | ||
| titleIsClickable: false, | ||
| subtitleLength: TEXT_LENGTH.NO_TEXT, | ||
| showFooter: false, | ||
| optionsType: OPTIONS_TYPE.NONE, | ||
| visible: false |
There was a problem hiding this comment.
It's weird to start from an empty ActionSheet.
| bottom: true, | ||
| centerH: true, | ||
| width: '95%', | ||
| height: _.isEmpty(list) && !gridOptions ? 150 : undefined, |
There was a problem hiding this comment.
Not sure what's the point of this; is this a use-case you've seen?
| centerH: true, | ||
| width: '95%', | ||
| height: _.isEmpty(list) && !gridOptions ? 150 : undefined, | ||
| //@ts-ignore |
There was a problem hiding this comment.
You should not need to ignore this, please fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incubator.ActionSheet
Changelog
Incubator.ActionSheet
Additional info
#3396