Skip to content

RNNav iOS 18 Compatibility #7990 #8132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 27, 2025
+6 −0
Merged

RNNav iOS 18 Compatibility #7990 #8132

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff73561
RNNav iOS 18 Compatibility #7990
markdevocht Oct 26, 2025
3a899f9
update missing device
markdevocht Oct 26, 2025
d75d97e
device update
markdevocht Oct 26, 2025
41fda3a
update for Orientation test - better implementation of setOrientation
markdevocht Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions e2e/Orientation.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ describe.e2e(':ios: orientation', () => {
await expect(element(by.id(TestIDs.LANDSCAPE_ELEMENT))).toBeVisible();
await device.setOrientation('portrait');
await expect(element(by.id(TestIDs.LANDSCAPE_ELEMENT))).toBeVisible();
await device.setOrientation('landscape');
await expect(element(by.id(TestIDs.LANDSCAPE_ELEMENT))).toBeVisible();
await elementById(TestIDs.DISMISS_BTN).tap();
await device.setOrientation('portrait');
});
});
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@
"type": "ios.simulator",
"device": {
"type": "iPhone 13 Pro Max",
"os": "15.5"
"os": "18.5"
}
},
"genymotion.emulator.name": {
Expand Down
2 changes: 1 addition & 1 deletion scripts/test-unit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ function runAndroidUnitTests() {
function runIosUnitTests() {
exec.execSync('npm run build');
exec.execSync('npm run pod-install');
testTarget('playground', 'iPhone 13', '15.5');
testTarget('playground', 'iPhone 13', '18.5');
}

function testTarget(scheme, device, OS = 'latest') {
Expand Down
Loading