Skip to content

Conversation

@ArmandPhilippot
Copy link
Member

@ArmandPhilippot ArmandPhilippot commented Nov 25, 2025

Description (required)

Fixes how we define cacheHint in a code snippet of experimental-flags/live-content-collections. I reused the version we have for the v6 docs, so this also adds imports.

Related issues & labels (optional)

  • Suggested label: code snippet update

@ArmandPhilippot ArmandPhilippot added the code snippet update Updates a code sample: typo, outdated code etc. label Nov 25, 2025
@netlify
Copy link

netlify bot commented Nov 25, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f3c0391
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/692614661e576b0008da1cea
😎 Deploy Preview https://deploy-preview-12790--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Nov 25, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/experimental-flags/live-content-collections.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@ArmandPhilippot ArmandPhilippot marked this pull request as draft November 25, 2025 14:17
@ArmandPhilippot ArmandPhilippot marked this pull request as ready for review November 25, 2025 14:18
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArmandPhilippot! I think I’m probably missing some context on this one, so feel free to disregard my feedback if it’s not helpful.

Co-authored-by: Chris Swithinbank <[email protected]>
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Armand!

It looks like re: carrying this over to #12604 it's just the addition of getLastModified that needs updating there, too?

(That PR is to v6, and is not yet updated to main... so I think the easiest thing to do is update 12604 to match right now. 😄 )

@ArmandPhilippot
Copy link
Member Author

ArmandPhilippot commented Nov 25, 2025

There are three lines to update in the v6 PR: the imports and getLastModifiedDate instead of the .sort() method currently. But I made a suggestion in that PR since I know exactly what changed. 😄

@ArmandPhilippot ArmandPhilippot merged commit 5a8f672 into withastro:main Nov 25, 2025
10 checks passed
@ArmandPhilippot ArmandPhilippot deleted the fix/live-content-collections branch November 25, 2025 20:48
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code snippet update Updates a code sample: typo, outdated code etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants