-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(live-content-collections): update cacheHint code snippet
#12790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(live-content-collections): update cacheHint code snippet
#12790
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
delucis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ArmandPhilippot! I think I’m probably missing some context on this one, so feel free to disregard my feedback if it’s not helpful.
src/content/docs/en/reference/experimental-flags/live-content-collections.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/reference/experimental-flags/live-content-collections.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Swithinbank <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Armand!
It looks like re: carrying this over to #12604 it's just the addition of getLastModified that needs updating there, too?
(That PR is to v6, and is not yet updated to main... so I think the easiest thing to do is update 12604 to match right now. 😄 )
|
There are three lines to update in the v6 PR: the imports and |
Description (required)
Fixes how we define
cacheHintin a code snippet ofexperimental-flags/live-content-collections. I reused the version we have for the v6 docs, so this also adds imports.Related issues & labels (optional)
code snippet update