-
-
Notifications
You must be signed in to change notification settings - Fork 3k
perf: switch to clack for CLI prompts #14589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
43081j
wants to merge
10
commits into
withastro:main
Choose a base branch
from
43081j:clack-prompts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+106
−206
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
36c662b
perf: switch to clack spinner
43081j 81e59be
perf: switch to clack for box rendering
43081j d82cfa1
perf: switch to clack for confirm prompts
43081j 9bbc2c2
Merge branch 'main' into clack-prompts
florian-lefebvre a39cadd
chore: use new spinner API
43081j 24e0ab4
chore: use bold confirm messages
43081j f672d5e
Merge branch 'main' into clack-prompts
43081j cb0aaeb
Merge branch 'main' into clack-prompts
florian-lefebvre 5585685
fix
florian-lefebvre 96372cf
fix
florian-lefebvre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import { confirm } from '@clack/prompts'; | ||
| import type { Prompt } from '../definitions.js'; | ||
|
|
||
| interface Options { | ||
| force: boolean; | ||
| } | ||
|
|
||
| export function createClackPrompt({ force }: Options): Prompt { | ||
| return { | ||
| async confirm({ message, defaultValue }) { | ||
| if (force) { | ||
| return true; | ||
| } | ||
| const response = await confirm({ | ||
| message, | ||
| initialValue: defaultValue, | ||
| }); | ||
| // Response is a symbol when cancelled | ||
| return response === true; | ||
| }, | ||
| }; | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spinner.errormakes the build fail currentlyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess because bombshell-dev/clack#406 is unreleased