Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve caption for CWV scores #1288

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve caption for CWV scores #1288

wants to merge 2 commits into from
+2 −1

Conversation

ascorbic
Copy link
Contributor

Adds a caption explaining what the scores mean. Wording perhaps could be improved.

Browser Test Checklist

I have tested this PR on at least three of the following browsers:

  • Chrome / Chromium
  • Firefox
  • Android Firefox
  • Safari
  • iOS Safari

@netlify Netlify
Copy link

netlify bot commented Oct 10, 2024 •
edited
Loading

✅ Deploy Preview for astro-www-2 ready!

Name Link
🔨 Latest commit 1d832b7
🔍 Latest deploy log https://app.netlify.com/sites/astro-www-2/deploys/6707c5ba3012550007045322
😎 Deploy Preview https://deploy-preview-1288--astro-www-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 5 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 95 (🟢 up 1 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

TheOtterlord
TheOtterlord approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It looks a little busy in small viewports. We could split it into two paragraphs with some margin between them, but it's not a major issue.
image

apatel369
apatel369 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@apatel369 apatel369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheOtterlord TheOtterlord TheOtterlord approved these changes

@apatel369 apatel369 apatel369 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ascorbic @apatel369 @TheOtterlord