chore(deps): upgrade linters

.github/workflows/lint.yml

@@ -19,9 +19,9 @@ jobs:
           go-version: '1.21.2'
 
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6
+        uses: golangci/golangci-lint-action@v7
         with:
-          version: v1.58
+          version: v2.0
 
   container:
     name: Containerfile

Makefile

@@ -41,9 +41,9 @@ lint: dependencies
 ## Loads all the dependencies to vendor directory
 .PHONY: dependencies
 dependencies:
-	go install golang.org/x/tools/cmd/goimports@v0.20.0
-	go install mvdan.cc/gofumpt@v0.6.0
-	go install github.com/daixiang0/[email protected].4
-	go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.58.1
+	go install golang.org/x/tools/cmd/goimports@v0.31
+	go install mvdan.cc/gofumpt@v0.7
+	go install github.com/daixiang0/[email protected]
+	go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2
 	go mod vendor
 	go mod tidy

bs/fs_linux.go

@@ -78,7 +78,14 @@ func virtioBlkDeviceCheck(pseudoFsDevPath string) bool {
 		)
 		return false
 	}
-	defer file.Close()
+	defer func() {
+		if err := file.Close(); err != nil {
+			slog.Error(
+				"Error closing file.",
+				slog.String("error", err.Error()),
+			)
+		}
+	}()
 
 	devtype := "None"
 	scanner := bufio.NewScanner(file)
@@ -117,7 +124,14 @@ func virtioBlkDeviceUuid(blockDev string) (uuid.UUID, error) {
 		)
 		panic("virtioBlkDeviceUuid")
 	}
-	defer file.Close()
+	defer func() {
+		if err := file.Close(); err != nil {
+			slog.Error(
+				"Error closing file.",
+				slog.String("error", err.Error()),
+			)
+		}
+	}()
 
 	scanner := bufio.NewScanner(file)
 	for scanner.Scan() {
@@ -194,7 +208,14 @@ func scsiDeviceCheck(pseudoFsDevPath string) bool {
 		)
 		return false
 	}
-	defer file.Close()
+	defer func() {
+		if err := file.Close(); err != nil {
+			slog.Error(
+				"Error closing file.",
+				slog.String("error", err.Error()),
+			)
+		}
+	}()
 
 	devtype := "None"
 	scanner := bufio.NewScanner(file)
@@ -233,7 +254,14 @@ func scsiDeviceUuid(blockDev string) (uuid.UUID, error) {
 		)
 		panic("scsiDeviceUuid")
 	}
-	defer file.Close()
+	defer func() {
+		if err := file.Close(); err != nil {
+			slog.Error(
+				"Error closing file.",
+				slog.String("error", err.Error()),
+			)
+		}
+	}()
 
 	scanner := bufio.NewScanner(file)
 	for scanner.Scan() {

cmd/koherence/check/bs.go

@@ -163,7 +163,9 @@ func bsCheckerCommand(clicontext *cli.Context) error {
 	b, err := BsMerge(machineInfos, bsFs, bsProvider)
 
 	if b != nil {
-		fmt.Fprintln(os.Stdout, string(b))
+		if _, err := fmt.Fprintln(os.Stdout, string(b)); err != nil {
+			slog.Error("failed to write to stdout", "err", err)
+		}
 	}
 
 	return err

cmd/koherence/debug/bs.go

@@ -33,7 +33,9 @@ func debugBs(clicontext *cli.Context) error {
 		return err
 	}
 
-	fmt.Fprintln(os.Stdout, string(b))
+	if _, err := fmt.Fprintln(os.Stdout, string(b)); err != nil {
+		slog.Error("failed to write to stdout", "err", err)
+	}
 
 	return nil
 }

cmd/koherence/debug/machine.go

@@ -52,7 +52,9 @@ func debugMachine(clicontext *cli.Context) error {
 		return err
 	}
 
-	fmt.Fprintln(os.Stdout, string(b))
+	if _, err := fmt.Fprintln(os.Stdout, string(b)); err != nil {
+		slog.Error("failed to write to stdout", "err", err)
+	}
 
 	return nil
 }

cmd/koherence/debug/openstack.go

@@ -34,7 +34,9 @@ func debugOpenstack(clicontext *cli.Context) error {
 		return err
 	}
 
-	fmt.Fprintln(os.Stdout, string(b))
+	if _, err := fmt.Fprintln(os.Stdout, string(b)); err != nil {
+		slog.Error("failed to write to stdout", "err", err)
+	}
 
 	return nil
 }

cmd/koherence/serve.go

@@ -20,7 +20,9 @@ var serveCommand = cli.Command{
 
 func pingHandler(w http.ResponseWriter, req *http.Request) {
 	w.WriteHeader(http.StatusOK)
-	fmt.Fprintln(w, "pong")
+	if _, err := fmt.Fprintln(w, "pong"); err != nil {
+		slog.Error("failed to write to http.ResponseWriter", "err", err)
+	}
 }
 
 func debugBsHandler(w http.ResponseWriter, req *http.Request) {
@@ -42,7 +44,9 @@ func debugBsHandler(w http.ResponseWriter, req *http.Request) {
 
 	w.Header().Set("Content-Type", "application/json")
 	w.WriteHeader(http.StatusOK)
-	fmt.Fprintln(w, string(b))
+	if _, err := fmt.Fprintln(w, string(b)); err != nil {
+		slog.Error("failed to write to http.ResponseWriter", "err", err)
+	}
 }
 
 func debugMachineFsHandler(w http.ResponseWriter, req *http.Request) {
@@ -63,7 +67,9 @@ func debugMachineFsHandler(w http.ResponseWriter, req *http.Request) {
 
 	w.Header().Set("Content-Type", "application/json")
 	w.WriteHeader(http.StatusOK)
-	fmt.Fprintln(w, string(b))
+	if _, err := fmt.Fprintln(w, string(b)); err != nil {
+		slog.Error("failed to write to http.ResponseWriter", "err", err)
+	}
 }
 
 func debugMachineOpenstackHandler(w http.ResponseWriter, req *http.Request) {
@@ -84,7 +90,9 @@ func debugMachineOpenstackHandler(w http.ResponseWriter, req *http.Request) {
 
 	w.Header().Set("Content-Type", "application/json")
 	w.WriteHeader(http.StatusOK)
-	fmt.Fprintln(w, string(b))
+	if _, err := fmt.Fprintln(w, string(b)); err != nil {
+		slog.Error("failed to write to http.ResponseWriter", "err", err)
+	}
 }
 
 func debugOpenstackHandler(w http.ResponseWriter, req *http.Request) {
@@ -108,7 +116,9 @@ func debugOpenstackHandler(w http.ResponseWriter, req *http.Request) {
 
 	w.Header().Set("Content-Type", "application/json")
 	w.WriteHeader(http.StatusOK)
-	fmt.Fprintln(w, string(b))
+	if _, err := fmt.Fprintln(w, string(b)); err != nil {
+		slog.Error("failed to write to http.ResponseWriter", "err", err)
+	}
 }
 
 func checkBsHandler(w http.ResponseWriter, req *http.Request) {
@@ -132,7 +142,9 @@ func checkBsHandler(w http.ResponseWriter, req *http.Request) {
 
 	w.Header().Set("Content-Type", "application/json")
 	w.WriteHeader(http.StatusOK)
-	fmt.Fprintln(w, string(b))
+	if _, err := fmt.Fprintln(w, string(b)); err != nil {
+		slog.Error("failed to write to http.ResponseWriter", "err", err)
+	}
 }
 
 func checkMachineHandler(w http.ResponseWriter, req *http.Request) {
@@ -167,7 +179,9 @@ func checkOpenstackMultiattachHandler(w http.ResponseWriter, req *http.Request)
 
 	w.Header().Set("Content-Type", "application/json")
 	w.WriteHeader(http.StatusOK)
-	fmt.Fprintln(w, string(b))
+	if _, err := fmt.Fprintln(w, string(b)); err != nil {
+		slog.Error("failed to write to http.ResponseWriter", "err", err)
+	}
 }
 
 func serveAllCommand(clicontext *cli.Context) error {

machine/openstack_linklocal.go

@@ -72,7 +72,14 @@ func fetchMetadataJson() (*openstackMetadata, error) {
 		)
 		return nil, err
 	}
-	defer resp.Body.Close()
+	defer func() {
+		if err := resp.Body.Close(); err != nil {
+			slog.Error(
+				"Error closing http response",
+				slog.String("error", err.Error()),
+			)
+		}
+	}()
 
 	if err = json.NewDecoder(resp.Body).Decode(&metadatas); err != nil {
 		slog.Error(