-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Monorepo #17159
base: dev
Are you sure you want to change the base?
chore: Monorepo #17159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this plugin is now included with yarn 4.0.1
apps/wire-webapp/.lintstagedrc.json
Outdated
{ | ||
"*": "prettier --ignore-unknown --write", | ||
"*.less": ["stylelint --fix"], | ||
"*.{js,jsx,ts,tsx}": ["eslint --fix"] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the way to go for a monorepo structure (see https://github.com/lint-staged/lint-staged?tab=readme-ov-file#how-to-use-lint-staged-in-a-multi-package-monorepo)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #17159 +/- ##
==========================================
+ Coverage 46.02% 47.19% +1.16%
==========================================
Files 746 1010 +264
Lines 24556 29849 +5293
Branches 5618 6274 +656
==========================================
+ Hits 11303 14086 +2783
- Misses 11823 14269 +2446
- Partials 1430 1494 +64 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #17159 +/- ##
==========================================
+ Coverage 46.31% 47.24% +0.92%
==========================================
Files 758 1011 +253
Lines 24904 29904 +5000
Branches 5714 6281 +567
==========================================
+ Hits 11535 14129 +2594
- Misses 11928 14284 +2356
- Partials 1441 1491 +50 |
|
|
This is a first step into having a monorepo structure for all our apps and packages.
The long run idea is to have
in the same repo along with the custom packages they all consume.
Scope
This first step will:
yarn
as the monorepo managerwebapp
to the monorepo (libraries will be added in a follow up PR)What is not included in this iteration:
TODO