feat: 1:1 proteus is not migrated to MLS - WPB-17393 #2973
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
Issue
We have an issue with one user that his 1:1 with a user from another team is still proteus on iOS, however it's MLS on Web. The result is a conversation on Web (and Android for another user) with a history, but an empty proteus conversation on iOS.
The logs from DD say that tis conversation
resolve 1-1 conversation failed: alreadyMigrated
. From all the logs and the fact that MLS conversation exists, but for some reason doesn't show up in the conversation list, we suspect that 1:1 MLS conversation is marked asmigratedToMLS
, butotherUser.oneOnOneConversation
is still Proteus.Why or how this happened is unknown. Most likely the conversation was migrated, but something overrode
otherUser.oneOnOneConversation
and set it back to the proteus conversation.In this PR I added one more condition to trigger messages migration and MLS conversation linking:
if
mlsConversation.migratedToMLS
is false andotherUser.oneOnOneConversation
is notmlsConversation
,we should attempt to migrate.
Also, since we have an insane amount of error logs like resolve 1-1 conversation failed: alreadyMigrated which are not an error but rather info, I changed their logging a bit.
Testing
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: