-
Notifications
You must be signed in to change notification settings - Fork 19
fix: CI broken due to images update - WPB-17488 #2964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit c1ecbcb. |
Datadog ReportBranch report: ✅ 0 Failed, 4786 Passed, 28 Skipped, 4m 54.68s Total Time |
Closing this in favor of keeping https://github.com/wireapp/wire-ios/pull/2971/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
CI broke because Cirrus-CI removed Xcode 15.4 from the image which contained the iOS 17.5 runtime.
As a fix here, we updated to use iOS 18.0 simulator
Note: there is an issue in Wire iOS where we don't run the German tests anymore. I'll create a separate ticket for this.
Testing