feat: Improve collapse - WPB-17259 #2961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # wire-ios/Wire-iOS Tests/ConversationMessageCell/ConversationMessageSectionControllerTests.swift # wire-ios/Wire-iOS Tests/ConversationMessageCell/ConversationMessageSnapshotTestCase.swift # wire-ios/Wire-iOS Tests/ConversationMessageCell/MessageActionsViewControllerTests.swift
netbe
changed the title
dmitrysimkin
requested review from
a team,
caldrian,
jullianm and
KaterinaWire
and removed request for
a team
Test Results4 458 tests 4 430 ✅ 7m 59s ⏱️ Results for commit 91dee48. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 4430 Passed, 28 Skipped, 4m 44.11s Total Time |
…7259 # Conflicts: # wire-ios/Wire-iOS Tests/ConversationMessageCell/ConversationMessageSectionControllerTests.swift # wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/Cells/ConfigurationMessageCell/Content/Text/ConversationCollapsedMessageCell.swift # wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/Cells/ConfigurationMessageCell/ConversationMessageSectionController.swift # wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/Cells/Utility/NSAttributedString+MessageFormatting.swift
|
@dmitrysimkin can you target develop as this is for 3.125 please? |
...ce/Conversation/Content/Cells/ConfigurationMessageCell/PrivateUserDefaults+CollapseKey.swift
Show resolved
Hide resolved
caldrian
reviewed
May 13, 2025
.../UserInterface/Conversation/Content/Cells/Utility/NSAttributedString+MessageFormatting.swift
Outdated
Show resolved
Hide resolved
...nversation/Content/Cells/ConfigurationMessageCell/ConversationMessageSectionController.swift
Outdated
Show resolved
Hide resolved
KaterinaWire
approved these changes
May 14, 2025
caldrian
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Testing
Describe how to test.
Optional: attachments like images, videos, etc.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: