Skip to content

feat: add test for UpdateKeyMaterial - WPB-17367 #2955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 6, 2025

Conversation

KaterinaWire
Copy link
Contributor

@KaterinaWire KaterinaWire commented Apr 29, 2025

BugWPB-17367 [Android] unlimited MLS jobs when sync goes live

Issue

Android clients have an issue updating key material. The idea behind this PR is to add a test that covers the issue found on Android, prove that we have the correct implementation, and prevent it from breaking it in the future.

The issue was:

  1. Android runs their renew key material job and finds 3 conversations requiring an update.
  2. When executing 2 out of 3 re-newals succeed
  3. Since one re-newal failed, the whole job also failed.
  4. The timer to check every 24h will not be reseted meaning it will try again and again and again on every time the app goes live.

Testing

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

Copy link
Contributor

github-actions bot commented Apr 29, 2025

Test Results

2 473 tests   2 472 ✅  4m 56s ⏱️
  263 suites      1 💤
    2 files        0 ❌

Results for commit 09d6182.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Apr 29, 2025

Datadog Report

Branch report: fix/add-more-tests-key-materials
Commit report: 3ebb78d
Test service: wire-ios-mono

✅ 0 Failed, 2472 Passed, 1 Skipped, 4m 46.9s Total Time

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a suggestion

@KaterinaWire KaterinaWire enabled auto-merge May 6, 2025 11:58
@KaterinaWire KaterinaWire added this pull request to the merge queue May 6, 2025
auto-merge was automatically disabled May 6, 2025 12:19

Pull Request is not mergeable

Merged via the queue into develop with commit 4f26100 May 6, 2025
10 checks passed
@KaterinaWire KaterinaWire deleted the fix/add-more-tests-key-materials branch May 6, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants