-
Notifications
You must be signed in to change notification settings - Fork 19
feat: add test for UpdateKeyMaterial - WPB-17367 #2955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results2 473 tests 2 472 ✅ 4m 56s ⏱️ Results for commit 09d6182. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 2472 Passed, 1 Skipped, 4m 46.9s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left a suggestion
Issue
Android clients have an issue updating key material. The idea behind this PR is to add a test that covers the issue found on Android, prove that we have the correct implementation, and prevent it from breaking it in the future.
The issue was:
Testing
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: