Skip to content

feat: swipe to react (#WPB-16545) #4008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025
Merged

feat: swipe to react (#WPB-16545) #4008

merged 2 commits into from
May 6, 2025

Conversation

sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Apr 30, 2025

TaskWPB-16545 [Android] Swipe left to react

https://wearezeta.atlassian.net/browse/WPB-16545

Swipe message left to react

swipe_to_react.mp4

Copy link
Contributor

@sbakhtiarov looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
614ae930972e69aa306dd20a3dd00a38f0981840 4d8b413250432b7935c4b87394ad0ca773182799

Is this intentional?

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 46.02%. Comparing base (fcb37fb) to head (21c505a).

Files with missing lines Patch % Lines
...conversations/messages/item/SwipeableMessageBox.kt 0.00% 8 Missing ⚠️
...e/android/ui/home/conversations/model/UIMessage.kt 0.00% 7 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4008      +/-   ##
===========================================
- Coverage    46.04%   46.02%   -0.03%     
===========================================
  Files          519      519              
  Lines        18081    18092      +11     
  Branches      3037     3042       +5     
===========================================
  Hits          8326     8326              
- Misses        8891     8902      +11     
  Partials       864      864              
Files with missing lines Coverage Δ
...d/ui/home/conversations/media/FileAssetsContent.kt 0.00% <ø> (ø)
.../conversations/messages/item/RegularMessageItem.kt 0.00% <ø> (ø)
...e/android/ui/home/conversations/model/UIMessage.kt 38.19% <0.00%> (-1.01%) ⬇️
...conversations/messages/item/SwipeableMessageBox.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcb37fb...21c505a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented May 6, 2025

@sbakhtiarov looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
614ae930972e69aa306dd20a3dd00a38f0981840 4d8b413250432b7935c4b87394ad0ca773182799

Is this intentional?

Copy link

sonarqubecloud bot commented May 6, 2025

Copy link
Contributor

github-actions bot commented May 6, 2025

Built wire-android-staging-compat-pr-4008.apk is available for download

Copy link
Contributor

github-actions bot commented May 6, 2025

Built wire-android-dev-debug-pr-4008.apk is available for download

@sbakhtiarov sbakhtiarov added this pull request to the merge queue May 6, 2025
Merged via the queue into develop with commit 23f81a8 May 6, 2025
13 of 14 checks passed
@sbakhtiarov sbakhtiarov deleted the feat/swipe-to-react branch May 6, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants