-
Notifications
You must be signed in to change notification settings - Fork 35
chore: remove some non-determinism #4000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Your app is not built reproducible in F-Droid, but we continuously test older versions on https://verification.f-droid.org/ and would like more and more apps to become repro Looking at this report: https://verification.f-droid.org/unsigned/com.wire_100083279.apk.diffoscope.html It seems easily fixable by updating the lib to 11.5.0 or later, as this was fixed in mikepenz/AboutLibraries#1056
|
nope @CLAassistant no can do, but anyone can pickup this change and whatever 😉 |
FYI as this is a trivial change, copyright does not apply, therefore a CLA is unnecessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution
It seems that the new version of AboutLibraries requires a newer version of core-ktx, which requires a newer compile version, so it isn't building 🙃 Hopefully these are the only surprises. |
IIRC, there is a config option in aboutlibraries to turn control the inclusion of the timestamp. The timestamp used to be default on, the change was to make it default off. So you could try keeping the same library version, then just setting it to not include the timestamp. |
This one: mikepenz/AboutLibraries#784 (comment) |
@vitorhugods @MohamadJaara to speed it up, I've applied the other fix, and you can remove it once the lib and (core-ktx) gets upgraded |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4000 +/- ##
===========================================
+ Coverage 46.01% 46.02% +0.01%
===========================================
Files 518 520 +2
Lines 18056 18108 +52
Branches 3031 3044 +13
===========================================
+ Hits 8309 8335 +26
- Misses 8889 8909 +20
- Partials 858 864 +6 see 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Your app is not built reproducible in F-Droid, but we continuously test older versions on https://verification.f-droid.org/ and would like more and more apps to become repro
Looking at this report: https://verification.f-droid.org/unsigned/com.wire_100083279.apk.diffoscope.html
It seems easily fixable by updating the lib to 11.5.0 or later, as this was fixed in mikepenz/AboutLibraries#1056