Skip to content

chore: remove some non-determinism #4000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

licaon-kter
Copy link

Your app is not built reproducible in F-Droid, but we continuously test older versions on https://verification.f-droid.org/ and would like more and more apps to become repro

Looking at this report: https://verification.f-droid.org/unsigned/com.wire_100083279.apk.diffoscope.html

It seems easily fixable by updating the lib to 11.5.0 or later, as this was fixed in mikepenz/AboutLibraries#1056

Your app is not built reproducible in F-Droid, but we continuously test older versions on https://verification.f-droid.org/ and would like more and more apps to become repro

Looking at this report: https://verification.f-droid.org/unsigned/com.wire_100083279.apk.diffoscope.html

It seems easily fixable by updating the lib to 11.5.0 or later, as this was fixed in mikepenz/AboutLibraries#1056
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@licaon-kter
Copy link
Author

nope @CLAassistant no can do, but anyone can pickup this change and whatever 😉

@eighthave
Copy link

FYI as this is a trivial change, copyright does not apply, therefore a CLA is unnecessary.

Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@MohamadJaara MohamadJaara changed the title Remove some non-determinism chore: remove some non-determinism Apr 23, 2025
@vitorhugods
Copy link
Member

It seems that the new version of AboutLibraries requires a newer version of core-ktx, which requires a newer compile version, so it isn't building 🙃

Hopefully these are the only surprises.

@eighthave
Copy link

IIRC, there is a config option in aboutlibraries to turn control the inclusion of the timestamp. The timestamp used to be default on, the change was to make it default off. So you could try keeping the same library version, then just setting it to not include the timestamp.

@licaon-kter
Copy link
Author

This one: mikepenz/AboutLibraries#784 (comment)

@licaon-kter
Copy link
Author

@vitorhugods @MohamadJaara to speed it up, I've applied the other fix, and you can remove it once the lib and (core-ktx) gets upgraded

Copy link

sonarqubecloud bot commented May 7, 2025

Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.02%. Comparing base (b9c9d3c) to head (cc397b2).
Report is 17 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4000      +/-   ##
===========================================
+ Coverage    46.01%   46.02%   +0.01%     
===========================================
  Files          518      520       +2     
  Lines        18056    18108      +52     
  Branches      3031     3044      +13     
===========================================
+ Hits          8309     8335      +26     
- Misses        8889     8909      +20     
- Partials       858      864       +6     

see 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c9d3c...cc397b2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MohamadJaara MohamadJaara added this pull request to the merge queue May 7, 2025
@MohamadJaara MohamadJaara removed this pull request from the merge queue due to a manual request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants