Skip to content

fix: fetch MLS public keys the same way as feature config [WPB-17161] #3991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release/candidate
Choose a base branch
from

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Apr 15, 2025

BugWPB-17161 [Android] Excessive frequency of fetching MLS public keys


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Fetching MLS public keys should be treated the same way as feature-configs.
https://wearezeta.atlassian.net/wiki/spaces/ENGINEERIN/pages/160858877/Feature+flags+and+feature+configuration#Periodic-fetch-of-configuration

Solutions

Add fetching MLS public keys to the AppSyncViewModel. Update kalium version to the one with MLS public keys changes to be able to use MLSPublicKeysSyncWorker (it executes fetch every 24h as well).

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk changed the title Fix/fetch mls public keys on foreground fix: fetch MLS public keys the same way as feature config [WPB-17161] Apr 15, 2025
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.92%. Comparing base (7601617) to head (57ef726).

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3991   +/-   ##
==================================================
  Coverage              45.91%   45.92%           
==================================================
  Files                    492      492           
  Lines                  17174    17176    +2     
  Branches                2862     2862           
==================================================
+ Hits                    7886     7888    +2     
  Misses                  8491     8491           
  Partials                 797      797           
Files with missing lines Coverage Δ
...otlin/com/wire/android/ui/home/AppSyncViewModel.kt 78.57% <100.00%> (+1.64%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7601617...57ef726. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Built wire-android-staging-compat-pr-3991.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant