ci: lint workflow files with actionlint - #282
Merged
Merged
Conversation
.github/workflows/*.yml was the only code in the repo with no automated checking. PR winsznx#255 removed contents: write and pull-requests: write from release.yml in the same rewrite that added a watchdog calling gh with no GH_TOKEN set -- every Release run failed until winsznx#225 caught up three changesets late. A linter would have caught the missing GH_TOKEN outright. Add actionlint as a CI job, plus a narrow guard asserting release.yml still declares contents: write and pull-requests: write, since that specific regression has now cost two outages. Closes winsznx#264
|
@jadonamite Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
winsznx
added a commit
that referenced
this pull request
Aug 30, 2026
The guard added in #282 grepped for the substrings "contents: write" and "pull-requests: write". Both also appear in the explanatory comments directly above the permissions block in release.yml: 10: # contents: write — changesets commits the version bump 11: # pull-requests: write — changesets opens/updates the release PR 14: contents: write 15: pull-requests: write So the guard passed on the comments alone. Deleting the actual permissions block — the exact #255 regression it exists to catch — would not have tripped it. Anchored to indented YAML keys instead. Verified both directions: passes against the real file, and fires when the block is stripped while the comments remain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
.github/workflows/*.ymlis the only code in the repo with no automated checking at all. PR #255 removedcontents: writeandpull-requests: writefromrelease.ymlin the same rewrite that added a watchdog callingghwith noGH_TOKENset — every Release run failed until #225 caught up three changesets late. A linter would have caught the missingGH_TOKENoutright.Fix
actionlintas a CI job.release.ymlstill declarescontents: writeandpull-requests: write, since that specific regression has now cost two outages.Closes #264