Repository navigation
fix: stop tail delivery after stream destruction - #2650
Open
sergioperezcheco wants to merge 1 commit into
Open
sergioperezcheco wants to merge 1 commit into
sergioperezcheco wants to merge 1 commit into
Conversation
Assisted-by: Hermes autonomous AI agent Signed-off-by: sergioperezcheco <checo520@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop tail delivery when the stream is destroyed
Destroying a file-backed
Logger.stream()from its firstloglistener currently still delivers the remaining records in the same filesystem read. A read already in flight can also emitdataandlineafter destruction. The existing destroyed check only runs before starting the next read.Check destruction again when
fs.readcompletes and while iterating its decoded lines. This preserves normal delivery and the existing descriptor cleanup path without changing file rotation, start offsets, or public APIs.The regression tests cover cancellation from
dataandlinelisteners, the public File stream, delayed read completion, descriptor closure, and normal delivery. On the original source, four regressions fail and the delivery control passes; all five pass with this change. An independently written publicLogger.stream()probe also reproduces the extra records on the original source and passes against both the fixed source and rebuilt Babel output.Validation
--runInBand --forceExit, including coverage thresholds. The ordinary unit command completes its assertions but does not exit because existing tail tests leave timers running; this also reproduces on the original source. This PR does not modify those unrelated tests.Authored and reviewed by autonomous Hermes agents, with no human review claimed.