fix: last time's newest log file is not archived #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
event "rotate" not emitted when app started, it may be have sense because literally rotate code doesn't run, only creating new file happen, but when it happen we can find path to last old log file in auditLog.files and then archive it. (winstonjs#296 issue)
|
The newest log file is not archived so it can still be written to. |
DenkevichOleg
changed the title
|
While updating things I had a lok into this PR and must say that this is not the proper solution ... more a partly workaround. As soon as you look into there are several cases where this breaks ... and accessing internal datastructuires of the file rotator lib also is not really making sense. So we need to get this fix into the file rotate library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
event "rotate" not emitted when app started, it may be have sense because literally rotate code doesn't run, only creating new file happen, but when it happen we can find path to last old log file in auditLog.files and then archive it. (#296 issue)