Update search path in configmake.h to Windows relative path#3
Open
hyh19962008 wants to merge 1 commit intowinlibs:masterfrom
Open
Update search path in configmake.h to Windows relative path#3hyh19962008 wants to merge 1 commit intowinlibs:masterfrom
hyh19962008 wants to merge 1 commit intowinlibs:masterfrom
Conversation
Member
|
|
Author
|
OK, I see. But I still think it's more intuitive and more natural to place all the runtime files under the main PHP folder. After all, this is the Windows way. |
|
While documented, it makes no sense to hardcode paths like this. With relative paths, everything works fine after extension activated in php.ini. Like any other extension. |
689f250 to
0ce12c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current search paths start with "/usr/local", which is an illegal path on Windows.
That means enchant will not be able to find any broker or dict, resulting in enchant_broker_describe() and enchant_broker_list_dicts() always return empty array in php.
I replace them with relative paths, so that they can work with the file structure of the current release tarball.