Skip to content

Align async currency missing-symbol behavior#50

Merged
wilsonfreitas merged 1 commit into
project-health-hardeningfrom
hardening/42-align-currency-missing-symbol-behavior
Jun 14, 2026
Merged

Align async currency missing-symbol behavior#50
wilsonfreitas merged 1 commit into
project-health-hardeningfrom
hardening/42-align-currency-missing-symbol-behavior

Conversation

@wilsonfreitas

Copy link
Copy Markdown
Owner

Summary

  • keep the existing sync missing-symbol contract as the shared contract
  • make async currency calls skip only CurrencyNotFoundError results in mixed requests
  • preserve propagation for non-not-found API, parsing, and HTTP failures
  • use a clearer all-invalid symbol error message
  • add sync/async tests for mixed, all-invalid, duplicate, dataframe, and text cases

Fixes #42

Verification

  • uv run pytest -m "not integration" (143 passed, 11 deselected)
  • uv run ruff check bcb/ tests/
  • uv run ruff format --check bcb/ tests/
  • uv run mypy bcb/
  • uv run --group docs sphinx-build -b html docs docs/_build/html

@wilsonfreitas
wilsonfreitas merged commit 993bc62 into project-health-hardening Jun 14, 2026
9 checks passed
@wilsonfreitas
wilsonfreitas deleted the hardening/42-align-currency-missing-symbol-behavior branch June 14, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant