Refactor MaximumSubarray and add tests#1281
Merged
Merged
Conversation
- Add file-level header explaining Kadane's algorithm with recurrence - Add Javadoc, fix internal types to long for overflow safety - Replace if/else with Math.max, fix typo, move main to bottom - Change null/empty to throw instead of returning 0 - Add 15 tests covering edge cases, all-negative, overflow, and more Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
longto prevent overflow when summing largeintvaluesTest plan
bazel test //src/test/java/com/williamfiset/algorithms/dp:MaximumSubarrayTestpassesbazel run //src/main/java/com/williamfiset/algorithms/dp:dp -- MaximumSubarrayproduces expected output🤖 Generated with Claude Code