Refactor EditDistance iterative and recursive, add tests#1279
Merged
Conversation
EditDistanceIterative: - Add file-level header, Javadoc, null checks, cross-reference to recursive - Simplify loop by extracting base cases into explicit initialization - Replace INF sentinel with clean base case logic - Add labeled examples in main EditDistanceRecursive: - Add file-level header, Javadoc, cross-reference to iterative - Make fields private - Replace custom min() varargs with Math.min - Add inline comments explaining base cases and transitions - Remove duplicate example in main Tests: - Add 14 tests covering null input, empty strings, insertions, deletions, substitutions, insert+delete vs substitute tradeoff, single char ops, and cross-validation between iterative and recursive solvers Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EditDistanceIterative.java: add docs, null checks, simplify loop structure, cross-reference recursive variantEditDistanceRecursive.java: add docs, make fields private, replace custommin()withMath.min, remove duplicate exampleEditDistanceIterativeTest.javaincluding cross-validation between both solversTest plan
bazel build //src/main/java/com/williamfiset/algorithms/dp:dppassesbazel test //src/test/java/com/williamfiset/algorithms/dp:EditDistanceIterativeTest— all 14 tests pass🤖 Generated with Claude Code