Refactor SuffixArrayFast: add docs, comments, and fix formatting#1273
Merged
Conversation
Apply SKILL.md conventions: fix package/header order, add detailed file-level docs explaining radix sort approach, add educational inline comments on the dense construct() method, use proper import instead of FQN, make fields private, and fix Big-O notation to O(n*log(n)). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
construct()methodO(n*log(n))Test plan
bazel test //src/test/java/.../suffixarray:SuffixArrayTest)🤖 Generated with Claude Code