Refactor SuffixArraySlow/Med, expand test coverage#1272
Merged
Conversation
Refactor SuffixArrayMed: fix package order, add file-level docs with algorithm explanation, replace FQN with import, make SuffixRankTuple private, add Javadoc, remove commented-out code and useless null assignments, improve inline comments. Fix Big-O notation to use explicit brackets: O(n*log(n)) not O(n log n). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
f160734 to
f70269d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
java.util.Arrayswith import, renamemin_lentominLen, makesuffixesprivate, add Javadoc toconstruct()SuffixRankTupleprivate, add Javadoc, remove large block of commented-out code inmain(), remove useless null assignments, improve inline commentsO(n*log(n))instead ofO(n log n)int[]constructor,getTextLength(), sorted suffix verification, randomized cross-validation (200 random strings across all 3 implementations)@BeforeEach, wildcard importTest plan
🤖 Generated with Claude Code