-
Notifications
You must be signed in to change notification settings - Fork 0
[codex] Add generic agent workflow baseline #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| --- | ||
| description: "Run a review, fix, and retest loop." | ||
| --- | ||
|
|
||
| # /review-cycle | ||
|
|
||
| Run a bounded review, fix, and retest loop using the standards of the current | ||
| repository and organization. | ||
|
|
||
| 1. Discover local standards before reviewing: | ||
| - read the nearest `AGENTS.md`, `CLAUDE.md`, `README.md`, and relevant docs | ||
| - inspect repo scripts, package tasks, CI config, and documented validation | ||
| - apply any generated org or profile instructions already installed for this agent | ||
| 2. Identify the target branch, base branch, changed files, open PR, CI state, | ||
| and project validation commands. | ||
| 3. Review the diff from multiple angles: correctness, maintainability, | ||
| security, product behavior, test coverage, docs, and consistency with local | ||
| standards. | ||
| 4. Convert actionable findings into a short fix list. Ignore preference-only | ||
| churn unless it conflicts with repo/org standards or blocks maintainability. | ||
| 5. Implement fixes while preserving unrelated user changes. | ||
| 6. Re-run relevant validation and update docs if behavior or workflow changed. | ||
| 7. Repeat the review once after fixes. Stop when no material findings remain or | ||
| a blocker requires human input. | ||
| 8. Report what changed, what was validated, which standards were applied, and | ||
| any residual risk. | ||
|
|
||
| If local repo or org instructions conflict with this workflow, follow the more | ||
| specific repo/org instruction and call out the conflict in the final report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| --- | ||
| description: "Prepare work and open or update a reviewable PR." | ||
| --- | ||
|
|
||
| # /ship | ||
|
|
||
| Prepare the current branch for review using the standards of the current | ||
| repository and organization. | ||
|
|
||
| 1. Discover local standards before changing behavior: | ||
| - read the nearest `AGENTS.md`, `CLAUDE.md`, `README.md`, and relevant docs | ||
| - inspect repo scripts, package tasks, CI config, and documented validation | ||
| - apply any generated org or profile instructions already installed for this agent | ||
| 2. Inspect the working tree, branch, upstream state, base branch, open PR, and | ||
| current CI state. | ||
| 3. Remove accidental noise, generated clutter, debug instrumentation, and | ||
| unrelated changes from the proposed diff. | ||
| 4. Confirm docs are updated when behavior, interfaces, config, ops, or | ||
| developer workflow changed. | ||
| 5. Run the narrowest meaningful validation first, then broader validation before | ||
| opening or updating the PR. | ||
| 6. Review the final diff for secrets, unrelated files, and avoidable churn. | ||
| 7. Create or update a ready-for-review PR with a concise description, | ||
| validation results, and known risks. | ||
| 8. Watch CI and fix straightforward failures until the branch is reviewable. | ||
|
|
||
| If local repo or org instructions conflict with this workflow, follow the more | ||
| specific repo/org instruction and call out the conflict in the final report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| --- | ||
| description: "Run a review, fix, and retest loop." | ||
| --- | ||
|
|
||
| # /review-cycle | ||
|
|
||
| Run a bounded review, fix, and retest loop using the standards of the current | ||
| repository and organization. | ||
|
|
||
| 1. Discover local standards before reviewing: | ||
| - read the nearest `AGENTS.md`, `CLAUDE.md`, `README.md`, and relevant docs | ||
| - inspect repo scripts, package tasks, CI config, and documented validation | ||
| - apply any generated org or profile instructions already installed for this agent | ||
| 2. Identify the target branch, base branch, changed files, open PR, CI state, | ||
| and project validation commands. | ||
| 3. Review the diff from multiple angles: correctness, maintainability, | ||
| security, product behavior, test coverage, docs, and consistency with local | ||
| standards. | ||
| 4. Convert actionable findings into a short fix list. Ignore preference-only | ||
| churn unless it conflicts with repo/org standards or blocks maintainability. | ||
| 5. Implement fixes while preserving unrelated user changes. | ||
| 6. Re-run relevant validation and update docs if behavior or workflow changed. | ||
| 7. Repeat the review once after fixes. Stop when no material findings remain or | ||
| a blocker requires human input. | ||
| 8. Report what changed, what was validated, which standards were applied, and | ||
| any residual risk. | ||
|
|
||
| If local repo or org instructions conflict with this workflow, follow the more | ||
| specific repo/org instruction and call out the conflict in the final report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| --- | ||
| description: "Prepare work and open or update a reviewable PR." | ||
| --- | ||
|
|
||
| # /ship | ||
|
|
||
| Prepare the current branch for review using the standards of the current | ||
| repository and organization. | ||
|
|
||
| 1. Discover local standards before changing behavior: | ||
| - read the nearest `AGENTS.md`, `CLAUDE.md`, `README.md`, and relevant docs | ||
| - inspect repo scripts, package tasks, CI config, and documented validation | ||
| - apply any generated org or profile instructions already installed for this agent | ||
| 2. Inspect the working tree, branch, upstream state, base branch, open PR, and | ||
| current CI state. | ||
| 3. Remove accidental noise, generated clutter, debug instrumentation, and | ||
| unrelated changes from the proposed diff. | ||
| 4. Confirm docs are updated when behavior, interfaces, config, ops, or | ||
| developer workflow changed. | ||
| 5. Run the narrowest meaningful validation first, then broader validation before | ||
| opening or updating the PR. | ||
| 6. Review the final diff for secrets, unrelated files, and avoidable churn. | ||
| 7. Create or update a ready-for-review PR with a concise description, | ||
| validation results, and known risks. | ||
| 8. Watch CI and fix straightforward failures until the branch is reviewable. | ||
|
|
||
| If local repo or org instructions conflict with this workflow, follow the more | ||
| specific repo/org instruction and call out the conflict in the final report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| --- | ||
| name: review-cycle | ||
| description: Use when the user invokes /review-cycle, review-cycle, or asks to run a review, fix, and retest loop before shipping. | ||
| metadata: | ||
| short-description: Review, fix, and retest work | ||
| --- | ||
|
|
||
| # Review Cycle | ||
|
|
||
| Run a bounded review, fix, and retest loop using the standards of the current | ||
| repository and organization. | ||
|
|
||
| 1. Discover local standards before reviewing: | ||
| - read the nearest `AGENTS.md`, `CLAUDE.md`, `README.md`, and relevant docs | ||
| - inspect repo scripts, package tasks, CI config, and documented validation | ||
| - apply any generated org or profile instructions already installed for this agent | ||
| 2. Identify the target branch, base branch, changed files, open PR, CI state, | ||
| and project validation commands. | ||
| 3. Review the diff from multiple angles: correctness, maintainability, | ||
| security, product behavior, test coverage, docs, and consistency with local | ||
| standards. | ||
| 4. Convert actionable findings into a short fix list. Ignore preference-only | ||
| churn unless it conflicts with repo/org standards or blocks maintainability. | ||
| 5. Implement fixes while preserving unrelated user changes. | ||
| 6. Re-run relevant validation and update docs if behavior or workflow changed. | ||
| 7. Repeat the review once after fixes. Stop when no material findings remain or | ||
| a blocker requires human input. | ||
| 8. Report what changed, what was validated, which standards were applied, and | ||
| any residual risk. | ||
|
|
||
| If local repo or org instructions conflict with this workflow, follow the more | ||
| specific repo/org instruction and call out the conflict in the final report. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| interface: | ||
| display_name: "Run review cycle" | ||
| short_description: "Review, fix, and retest work." | ||
| policy: | ||
| allow_implicit_invocation: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| interface: | ||
| display_name: "Run review cycle" | ||
| short_description: "Review, fix, and retest work." | ||
| policy: | ||
| allow_implicit_invocation: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,31 @@ | ||
| --- | ||
| name: ship | ||
| description: Prepare work and create a ready-to-review PR. | ||
| description: Use when the user invokes /ship, ship, or asks to prepare current work for review or open/update a pull request. | ||
| metadata: | ||
| short-description: Prepare and open a reviewable PR | ||
| --- | ||
|
|
||
| Prepare the current branch for review. | ||
| # Ship | ||
|
|
||
| 1. Clean up code and remove noise | ||
| 2. Ensure docs are updated | ||
| 3. Run local validation (lint, tests, etc.) | ||
| 4. Review diff | ||
| 5. Create/update PR with clear description | ||
| 6. Watch CI and fix simple failures | ||
| Prepare the current branch for review using the standards of the current | ||
| repository and organization. | ||
|
|
||
| 1. Discover local standards before changing behavior: | ||
| - read the nearest `AGENTS.md`, `CLAUDE.md`, `README.md`, and relevant docs | ||
| - inspect repo scripts, package tasks, CI config, and documented validation | ||
| - apply any generated org or profile instructions already installed for this agent | ||
| 2. Inspect the working tree, branch, upstream state, base branch, open PR, and | ||
| current CI state. | ||
| 3. Remove accidental noise, generated clutter, debug instrumentation, and | ||
| unrelated changes from the proposed diff. | ||
| 4. Confirm docs are updated when behavior, interfaces, config, ops, or | ||
| developer workflow changed. | ||
| 5. Run the narrowest meaningful validation first, then broader validation before | ||
| opening or updating the PR. | ||
| 6. Review the final diff for secrets, unrelated files, and avoidable churn. | ||
| 7. Create or update a ready-for-review PR with a concise description, | ||
| validation results, and known risks. | ||
| 8. Watch CI and fix straightforward failures until the branch is reviewable. | ||
|
|
||
| If local repo or org instructions conflict with this workflow, follow the more | ||
| specific repo/org instruction and call out the conflict in the final report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| { | ||
| "schema": "https://willgriffin.dev/agent-manifest/v1", | ||
| "layer": "dotfiles", | ||
| "priority": 10, | ||
| "agent_docs": [ | ||
| { | ||
| "id": "dotfiles.codex-defaults", | ||
| "targets": ["agents", "codex"], | ||
| "path": ".codex/AGENTS.md" | ||
| } | ||
| ], | ||
| "commands": [ | ||
| { | ||
| "agent": "claude", | ||
| "name": "ship", | ||
| "path": ".agents/commands/claude/ship.md", | ||
| "description": "Prepare work and open or update a reviewable PR" | ||
| }, | ||
| { | ||
| "agent": "claude", | ||
| "name": "review-cycle", | ||
| "path": ".agents/commands/claude/review-cycle.md", | ||
| "description": "Run a review, fix, and retest loop" | ||
| }, | ||
| { | ||
| "agent": "codex", | ||
| "name": "ship", | ||
| "path": ".agents/commands/codex/ship.md", | ||
| "description": "Prepare work and open or update a reviewable PR" | ||
| }, | ||
| { | ||
| "agent": "codex", | ||
| "name": "review-cycle", | ||
| "path": ".agents/commands/codex/review-cycle.md", | ||
| "description": "Run a review, fix, and retest loop" | ||
| } | ||
| ], | ||
| "skills": [ | ||
| { | ||
| "agent": "codex", | ||
| "name": "ship", | ||
| "path": ".agents/skills/ship", | ||
| "description": "Prepare work and open or update a reviewable PR" | ||
| }, | ||
| { | ||
| "agent": "codex", | ||
| "name": "review-cycle", | ||
| "path": ".agents/skills/review-cycle", | ||
| "description": "Run a review, fix, and retest loop" | ||
| }, | ||
| { | ||
| "agent": "codex", | ||
| "name": "resolve", | ||
| "path": ".agents/skills/resolve", | ||
| "description": "Resolve actionable PR review feedback" | ||
| } | ||
| ], | ||
| "env_requirements": [], | ||
| "services": [] | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.