Switch from xml to php for service configuration #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W0rma
force-pushed
the
xml-to-php-service-configuration
branch
from
8d2c182 to
025527c
Compare
dmaicher
reviewed
Nov 22, 2025
| "php": "^8.1", | ||
| "jms/serializer-bundle": "^3.10 || ^4.2 || ^5.4", | ||
| "symfony/dependency-injection": "^5.4 || ^6.0 || ^7.0", | ||
| "symfony/expression-language": "~3.0 || ~4.0 || ~5.0 || ~6.0 || ~7.0", |
There was a problem hiding this comment.
would it make sense to drop support for symfony 3 and 4 completely then? I mean they are long dead anyway
There was a problem hiding this comment.
I'm also proposing to remove it for willdurand/Hateoas#343 so it wouldn't make sense to support it here then. But maybe let's wait for a maintainer
Collaborator
|
Now that willdurand/Hateoas#343 is merged, is there anything that needs to changed into this? |
Using the xml format is deprecated in symfony 7.4
W0rma
force-pushed
the
xml-to-php-service-configuration
branch
from
025527c to
babfac8
Compare
Contributor
Author
@goetas This PR is ready to merge. Alternatively you could just merge #119 which is build on top of this PR + adds support for symfony 8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the xml format is deprecated in symfony 7.4 (see https://symfony.com/blog/new-in-symfony-7-4-deprecated-xml-configuration).
I used https://github.com/GromNaN/symfony-config-xml-to-php/ to convert the xml files.