Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-6937] Testing of write-attribute calls is low for the Elytron… #6159

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

pedro-hos
Copy link
Contributor

@pedro-hos pedro-hos commented Sep 2, 2024

@pedro-hos pedro-hos marked this pull request as draft September 2, 2024 20:22
@wildfly-ci
Copy link

Hello, pedro-hos. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.

@yersan
Copy link
Collaborator

yersan commented Sep 3, 2024

/ok-to-test

@wildfly-ci

This comment was marked as off-topic.

@wildfly-ci
Copy link

Core -> Full Integration Build 14145 outcome was UNKNOWN using a merge of df2416d
Summary: Canceled (Tests passed: 3946, ignored: 55; Step 6/7) Build time: 03:24:27

@wildfly-ci

This comment was marked as off-topic.

@pedro-hos pedro-hos marked this pull request as ready for review September 8, 2024 20:55
@yersan yersan requested a review from fjuma September 10, 2024 15:34
@yersan
Copy link
Collaborator

yersan commented Sep 10, 2024

Test failure at Full integration - Windows in unrelated

Copy link

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

@github-actions github-actions bot added the Stale label Oct 26, 2024
@pedro-hos
Copy link
Contributor Author

Hello @fjuma do you think that we can have this merged or do I need to make some change?

@github-actions github-actions bot removed the Stale label Oct 27, 2024
Copy link

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

@github-actions github-actions bot added the Stale label Dec 11, 2024
@yersan
Copy link
Collaborator

yersan commented Jan 28, 2025

/retest

@github-actions github-actions bot removed the Stale label Jan 29, 2025
@pedro-hos
Copy link
Contributor Author

@yersan the PR still failing on Full Integration Windows, but seems not related to my changes.

@yersan
Copy link
Collaborator

yersan commented Feb 14, 2025

@pedro-hos It is unrelated, the Windows test is an integration test on WildFly testsuite, and your PR does not modify any Elytron base code

@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Feb 14, 2025
@yersan yersan merged commit 4ec570c into wildfly:main Feb 14, 2025
11 of 12 checks passed
@yersan
Copy link
Collaborator

yersan commented Feb 14, 2025

Thanks @pedro-hos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants