Merge branch 'release/1.0.0-rc1'

CONTRIBUTING.md

@@ -0,0 +1,28 @@
+# How to contribute
+One of the goal of Wilcommerce is growing through the contributions of the community.<br/>
+If you have any issue, features or patches to submit, please follow this few guidelines.
+
+## Getting Started
+- Make sure you have a [GitHub account](https://github.com/join)
+- Check if your feature or bug is already in our issues.<br/>
+If not [create a new issue](https://github.com/wilcommerce/Wilcommerce.Catalog/issues) and describe it clearly. 
+- If it's a bug include also the steps to reproduce it and tell us the Wilcommerce version you have encountered it on.
+- Fork the repository on GitHub.
+
+## Making Changes
+- Create a new feature branch in your fork starting from the develop branch.
+- Make commits of logical units.
+- Check for unnecessary whitespace with ```git diff --check``` before committing.
+- Make sure your commit messages are in the proper format.
+- Write unit tests adding your test class to the **Wilcommerce.Catalog.Test** project.
+- Run **all** the tests to avoid breaking changes.
+
+## Submitting Changes
+- Push your changes to your feature branch in your fork.
+- [Submit a pull request](https://github.com/wilcommerce/Wilcommerce.Catalog/pulls)
+
+# Additional Resources
+- [GitHub Documentation](https://help.github.com/)
+- [GitHub Flow](https://help.github.com/articles/github-flow/)
+- [Working with forks](https://help.github.com/articles/working-with-forks/)
+- [Submit pull request](https://help.github.com/articles/proposing-changes-to-your-work-with-pull-requests/)

README.md

@@ -2,7 +2,7 @@
 Wilcommerce Catalog contains all the components to build a catalog system.
 
 ## Installation
-Nuget package available here https://www.nuget.org/packages/Wilcommerce.Catalog/1.0.0-beta4
+Nuget package available here [https://www.nuget.org/packages/Wilcommerce.Catalog/1.0.0-rc1](https://www.nuget.org/packages/Wilcommerce.Catalog/1.0.0-rc1)
 
 ## Models
 The **Models** namespace contains all the classes representing the components useful for building a catalog (i.e. Category, Product, Brand, etc.).
@@ -16,4 +16,7 @@ This namespace contains the interface which gives a readonly access to the compo
 Using this command component you can manage the persistence of all the catalog entities.
 
 ## Events
-In the **Events** namespace there are all the events that could happen after an action made on a catalog component.
+In the **Events** namespace there are all the events that could happen after an action made on a catalog component.
+
+# Contributing
+If you want to contribute to Wilcommerce please, check the [CONTRIBUTING](CONTRIBUTING.md) file.

Wilcommerce.Catalog.Test/Models/CategoryTest.cs

@@ -62,7 +62,7 @@ public void Category_IsVisible_From_Today()
 
             category.SetAsVisible(today);
 
-            Assert.Equal(true, category.IsVisible);
+            Assert.True(category.IsVisible);
             Assert.Equal(today, category.VisibleFrom);
         }
 
@@ -279,7 +279,7 @@ public void Hide_Should_Set_IsVisible_To_False()
             category.SetAsVisible();
             category.Hide();
 
-            Assert.Equal(false, category.IsVisible);
+            Assert.False(category.IsVisible);
             Assert.Equal(DateTime.Now.ToString("yyyy-MM-dd"), category.VisibleTo?.ToString("yyyy-MM-dd"));
         }
     }

Wilcommerce.Catalog.Test/Models/ProductTest.cs

@@ -301,7 +301,7 @@ public void Product_SetOnSale_Set_SaleDate_And_IsOnSale_To_True()
 
             product.SetOnSale(onSaleFrom, onSaleTo);
 
-            Assert.Equal(true, product.IsOnSale);
+            Assert.True(product.IsOnSale);
             Assert.Equal(onSaleFrom, product.OnSaleFrom);
             Assert.Equal(onSaleTo, product.OnSaleTo);
         }
@@ -320,7 +320,7 @@ public void Product_RemoveFromSale_Set_OnSaleTo_To_Now_And_IsOnSale_To_False()
 
             product.RemoveFromSale(endSale);
 
-            Assert.Equal(false, product.IsOnSale);
+            Assert.False(product.IsOnSale);
             Assert.Equal(endSale, product.OnSaleTo);
         }
 
@@ -701,7 +701,7 @@ public void ApproveReview_Should_Set_Approved_To_True()
             product.ApproveReview(review.Id);
 
             var rev = product.Reviews.First(r => r.Id == review.Id);
-            Assert.Equal(true, rev.Approved);
+            Assert.True(rev.Approved);
         }
 
         [Fact]
@@ -734,7 +734,7 @@ public void RemoveReviewApproval_Should_Set_Approved_To_False()
             product.RemoveReviewApproval(review.Id);
 
             var rev = product.Reviews.First(r => r.Id == review.Id);
-            Assert.Equal(false, rev.Approved);
+            Assert.False(rev.Approved);
         }
 
         [Fact]

Wilcommerce.Catalog.Test/Wilcommerce.Catalog.Test.csproj

@@ -0,0 +1,25 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFramework>netcoreapp2.0</TargetFramework>
+    <AssemblyName>Wilcommerce.Catalog.Test</AssemblyName>
+    <PackageId>Wilcommerce.Catalog.Test</PackageId>
+    <GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
+    <PackageTargetFallback>$(PackageTargetFallback);dnxcore50;portable-net45+win8</PackageTargetFallback>
+    <RuntimeFrameworkVersion>2.0</RuntimeFrameworkVersion>
+    <GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
+    <GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
+    <GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <ProjectReference Include="..\src\Wilcommerce.Catalog\Wilcommerce.Catalog.csproj" />
+  </ItemGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.3.0" />
+    <PackageReference Include="xunit.runner.visualstudio" Version="2.3.0" />
+    <PackageReference Include="xunit" Version="2.3.0" />
+  </ItemGroup>
+
+</Project>

Wilcommerce.Catalog.sln

@@ -1,21 +1,23 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio 14
-VisualStudioVersion = 14.0.25420.1
+# Visual Studio 15
+VisualStudioVersion = 15.0.26730.16
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{17D0648C-C73C-45B9-9F18-09F2EC133F6D}"
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{92656DEA-8893-44A4-8B61-2B3C9A32967F}"
 	ProjectSection(SolutionItems) = preProject
-		global.json = global.json
+		.gitignore = .gitignore
+		CONTRIBUTING.md = CONTRIBUTING.md
+		LICENSE = LICENSE
 		README.md = README.md
 	EndProjectSection
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "test", "test", "{E9262FCE-9E56-4E6E-9CA7-90BC9639AE84}"
 EndProject
-Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "Wilcommerce.Catalog", "src\Wilcommerce.Catalog\Wilcommerce.Catalog.xproj", "{F7052383-5A0C-4CEB-B9E7-4C7EB2C3C6EB}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Wilcommerce.Catalog", "src\Wilcommerce.Catalog\Wilcommerce.Catalog.csproj", "{F7052383-5A0C-4CEB-B9E7-4C7EB2C3C6EB}"
 EndProject
-Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "Wilcommerce.Catalog.Test", "Wilcommerce.Catalog.Test\Wilcommerce.Catalog.Test.xproj", "{93EC4EBB-F671-4D6B-8A63-2D912E796DED}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Wilcommerce.Catalog.Test", "Wilcommerce.Catalog.Test\Wilcommerce.Catalog.Test.csproj", "{93EC4EBB-F671-4D6B-8A63-2D912E796DED}"
 EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
@@ -39,4 +41,7 @@ Global
 		{F7052383-5A0C-4CEB-B9E7-4C7EB2C3C6EB} = {17D0648C-C73C-45B9-9F18-09F2EC133F6D}
 		{93EC4EBB-F671-4D6B-8A63-2D912E796DED} = {E9262FCE-9E56-4E6E-9CA7-90BC9639AE84}
 	EndGlobalSection
+	GlobalSection(ExtensibilityGlobals) = postSolution
+		SolutionGuid = {0BDAED63-DC5E-4FC5-8BDC-94BD12A98405}
+	EndGlobalSection
 EndGlobal