Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More browser compatibility fixes #87

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

More browser compatibility fixes #87

wants to merge 7 commits into from

Conversation

smrohrer
Copy link
Collaborator

  • Eliminated vw and vh units so the site displays correctly in older browsers that don't support them.
  • Refactored the JS for the expandable partner profile from ES6 so it works in older browsers.
  • Changed the "banner form" on the "Submit Video" page to a scrollable div with a fixed height to prevent it from running into the footer in some cases. What are your thoughts on this design? Mobile behavior is same as before.

Elements are now sized and positioned correctly in:

  • IE 9 (2011)
  • Firefox 3.6 (2010)
  • Chrome 15 (2011)
  • Opera 11.6 (2011)
  • Safari 5 (2010)

The remaining browser compatibility issue is support for pseudo-elements. The front page has white text with pseudo-element backgrounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogreudell bogreudell Awaiting requested review from bogreudell

@FredericoAndrade FredericoAndrade Awaiting requested review from FredericoAndrade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@smrohrer