Closed
Conversation
Version bump prom-client. Add a config option to collect default metrics (including GC). This should be enable only when running with no workers.
Throw an excpetion if metrics.prometheus.collect_default is enabled in cluster mode.
Add a noop type of metric not registered by service-runner Metric interface. This is used to delegate collection of default prometheus metrics to prom-client.collectDefaultMetrics.
jdforrester
approved these changes
May 4, 2024
Member
jdforrester
left a comment
jdforrester
left a comment
There was a problem hiding this comment.
This seems reasonable; shall we try it and see?
jdforrester
reviewed
May 4, 2024
| "prom-client": "^11.5.3", | ||
| "prom-client": "^12.0.0", | ||
| "semver": "^7.1.2", | ||
| "service-runner": "^3.1.0", |
Member
There was a problem hiding this comment.
We shouldn't load ourself. :-)
Member
|
Have pushed a rebase version as #256 (as I can't push to your fork). |
Member
|
Overtaken by #256. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am opening this WIP PR to validate direction and collect feedback on an approach to enable prometheus default metrics collection.
Happy to drop / rebase atop other work we might have in flight.
Implementation details have been discussed in:
Bug: https://phabricator.wikimedia.org/T350180